Skip to content

HOTFIX-733: Fix broken Mastr.to_csv by removing stray kwargs#736

Merged
Simon-Will merged 1 commit intoOpenEnergyPlatform:developfrom
Simon-Will:hotfix-733-fix-broken-csv-function
Apr 13, 2026
Merged

HOTFIX-733: Fix broken Mastr.to_csv by removing stray kwargs#736
Simon-Will merged 1 commit intoOpenEnergyPlatform:developfrom
Simon-Will:hotfix-733-fix-broken-csv-function

Conversation

@Simon-Will
Copy link
Copy Markdown
Contributor

@Simon-Will Simon-Will commented Apr 8, 2026 •
edited
Loading

Summary of the discussion

@Postiii pointed out in #733 that the to_csv method was broken with the 0.17.0 release. I'm fixing this here.

Type of change (CHANGELOG.md)

Updated

  • Fix broken Mastr.to_csv function by removing stray **kwargs

Workflow checklist

  • Checked that Mastr.to_csv works with this fix.

Automation

Closes #733

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Simon-Will Simon-Will self-assigned this Apr 8, 2026
@Simon-Will Simon-Will mentioned this pull request Apr 8, 2026
Closed
2 tasks
@Simon-Will
Copy link
Copy Markdown
Contributor Author

Simon-Will commented Apr 8, 2026

This is ready from my point of view. It's a trivial fix.

@Simon-Will Simon-Will requested a review from FlorianK13 April 8, 2026 13:04
@Simon-Will Simon-Will mentioned this pull request Apr 8, 2026
Open
20 tasks
FlorianK13
FlorianK13 approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@FlorianK13 FlorianK13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @Simon-Will you can merge if you want

@FlorianK13
Copy link
Copy Markdown
Member

FlorianK13 commented Apr 13, 2026 •
edited
Loading

Usually we would do hotfixes by branching and merging back to production, so that hotfixes do not interfere feature development such as #718

image

However merging to production would mean a new release right away, and I don't have time for that this week :/ Maybe @pt-kkraemer or @nesnoj do?

@Simon-Will
Copy link
Copy Markdown
Contributor Author

Simon-Will commented Apr 13, 2026

I take it that I can merge this into develop in this case. So I'm doing that now.

I would also have some time for a release this week, but I haven't done it before. I see your issue from the 0.17.0 release and could try to follow it. But I would appreciate if one of you has time to do it together, @pt-kkraemer or @nesnoj. :)

@Simon-Will Simon-Will merged commit e4fdbe5 into OpenEnergyPlatform:develop Apr 13, 2026
0 of 9 checks passed
@nesnoj
Copy link
Copy Markdown
Collaborator

nesnoj commented Apr 13, 2026

Hey! Thx for the hotfix!
I can take care of the release, we could also do it together if you like @Simon-Will - e.g. today at 4pm?

@Simon-Will
Copy link
Copy Markdown
Contributor Author

Simon-Will commented Apr 13, 2026

Works for me!

@nesnoj nesnoj mentioned this pull request Apr 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FlorianK13 FlorianK13 FlorianK13 approved these changes

Assignees

@Simon-Will Simon-Will

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Broken .to_csv function

4 participants

@Simon-Will @FlorianK13 @nesnoj @simonwill-nextkraftwerke